My first time doing something like this need some feedback